[Backport-2.x] Fix CodecTests#8591
Merged
reta merged 1 commit intoopensearch-project:2.xfrom Jul 10, 2023
Merged
Conversation
Contributor
Gradle Check (Jenkins) Run Completed with:
|
b57b13b to
3343a50
Compare
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
reta
approved these changes
Jul 10, 2023
3343a50 to
48ca263
Compare
sachinpkale
approved these changes
Jul 10, 2023
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
|
@sarthakaggarwal97 should we move it from draft state? or there is something else to fix? |
6 tasks
Member
|
@reta good to go? |
6 tasks
Contributor
|
Thank you @sarthakaggarwal97 ! |
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-8591-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 90bd4dd4bf5600b65e03f5ed4fa8144f175185b7
# Push it to GitHub
git push --set-upstream origin backport/backport-8591-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.xThen, create a pull request where the |
Member
|
@sarthakaggarwal97 can you raise a manual PR to 2.x? |
Contributor
Author
@owaiskazi19 this PR into 2.x itself. We don't need a backport |
Member
Ah my bad. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes CodecTests for backported PR #8312
Related Issues
Resolves #7555
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.