[Backport 3.6] [Bug] Fix bug when dimension <= 56 in Faiss SQ.#3233
Closed
opensearch-trigger-bot[bot] wants to merge 6 commits into3.6from
Closed
[Backport 3.6] [Bug] Fix bug when dimension <= 56 in Faiss SQ.#3233opensearch-trigger-bot[bot] wants to merge 6 commits into3.6from
opensearch-trigger-bot[bot] wants to merge 6 commits into3.6from
Conversation
- Route SpaceType.HAMMING to a dedicated createHammingScorer via FlatVectorsScorerProvider for memory-optimized binary vector search - Propagate fieldInfo to byte-target createScorer APIs for space-type-aware scorer resolution Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
Signed-off-by: Dooyong Kim <kdooyong@amazon.com>
#3217) Signed-off-by: Navneet Verma <navneev@amazon.com>
Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
#3207) * Refactor ExactSearcher to use VectorScorer instead of ExactKNNIterator Replace the ExactKNNIterator-based exact search with Lucene's VectorScorer API, delegating scorer creation to VectorScorers factory. This eliminates the need for multiple iterator subclasses (VectorIdsExactKNNIterator, BinaryVectorIdsExactKNNIterator, and their nested variants) by using VectorScorers.createScorer which handles vector type dispatch and nested wrapping via NestedBestChildVectorScorer. - Replace getKNNIterator with createVectorScorer using VectorScorers factory - Use VectorScorerMode (SCORE/RESCORE) to control quantization path - Remove getMatchedDocsIterator conjunction logic (handled by scorer) - Remove direct dependency on KNNFloatVectorValues, KNNByteVectorValues, KNNBinaryVectorValues and all ExactKNNIterator subclasses Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> * Use VectorScorer bulk scoring in ExactSearcher Replace doc-by-doc iterator scoring with Lucene's VectorScorer.Bulk API and DocAndFloatFeatureBuffer for batch processing. This enables batch skipping when the max score of a batch is below the current threshold, matching the pattern used in Lucene's AbstractKnnVectorQuery.exactSearch. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> * Fix ADC score calculation for cosine Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> * Fix iterator index Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> * Code clean up Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> * Remove iterator previously used by exactsearcher Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> * Add unit tests and clean up some more code Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> --------- Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
Signed-off-by: Dooyong Kim <kdooyong@amazon.com>
opensearch-trigger-bot
bot
requested review from
0ctopus13prime,
VijayanB,
Vikasht34,
heemin32,
jmazanec15,
junqiu-lei,
luyuncheng,
martin-gaievski,
naveentatikonda,
navneet1v,
ryanbogan,
shatejas and
vamshin
as code owners
naveentatikonda
previously approved these changes
Mar 31, 2026
0ctopus13prime
force-pushed
the
backport/backport-3229-to-3.6
branch
from
f5786a5 to
70ec782
Compare
0ctopus13prime
force-pushed
the
backport/backport-3229-to-3.6
branch
from
70ec782 to
77ac70e
Compare
Collaborator
|
Ah, messed up git commit history, will manually raise a new backport PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 77ac70e from #3229