Create HTTP contexts for legacy resource name#18
Merged
Conversation
Contributor
|
There is also the RCA API in 9600 port. Maybe we need to update that as well? Or, does this cover that? |
Codecov Report
@@ Coverage Diff @@
## main #18 +/- ##
=======================================
Coverage ? 76.99%
Complexity ? 3182
=======================================
Files ? 368
Lines ? 18360
Branches ? 1396
=======================================
Hits ? 14136
Misses ? 3732
Partials ? 492 Continue to review full report at Codecov.
|
dblock
suggested changes
May 24, 2021
Member
dblock
left a comment
dblock
left a comment
There was a problem hiding this comment.
This needs tests and, if possible, to mark the old route deprecated.
src/main/java/org/opensearch/performanceanalyzer/PerformanceAnalyzerApp.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Joshua Tokle <joshtok@amazon.com>
jotok
force-pushed
the
rest-backward-compat
branch
from
6b9997d to
efa66eb
Compare
sruti1312
approved these changes
May 24, 2021
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
We want the Performance Analyzer agent API for OpenSearch to be backward compatible with OpenDistro.
Describe the solution you are proposing
Adding HttpContexts that will resolve the old
/_opendistroresource name.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.