Add backward compatible resource names to RcaController#19
Merged
Conversation
Signed-off-by: Joshua Tokle <joshtok@amazon.com>
sruti1312
approved these changes
May 25, 2021
Contributor
|
Build is failing because of a failing test. We have retries enabled and this test is passing in next retry, but still leading to test failure. We need to fix this issue where build checks all the iterations instead of just the last one. Create an issue to track and fix this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joshua Tokle joshtok@amazon.com
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
The previous backward compatibility PR (#18) didn't update RcaController.
Describe the solution you are proposing
Add backward compatibility to resources defined in RcaController.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.