Conversation
Signed-off-by: Sruti Parthiban <partsrut@amazon.com>
kjoseph07
approved these changes
Aug 16, 2021
sruti1312
added a commit
that referenced
this pull request
Aug 25, 2021
Signed-off-by: Sruti Parthiban <partsrut@amazon.com>
sruti1312
added a commit
that referenced
this pull request
Aug 25, 2021
* Adding the initial changes for purger fix * Removing deletionInterval from MetricConfig class * Moving the removeMetrics() back to PerformanceAnalyzerMetrics class * Adding Event log file deletion + deletion time metric * Updating the EventLogFilesDeleted metrics * Moving METRICS_WRITE_ERROR metric to Named Counter, updating deleteFiles() signature * nit: Removing an unused import * Addressing the spotbug failure * Fixing the linker error, updating from docs-beta to official documentation * Excluding https://www.envoyproxy.io/ from link checker. Failing with too many redirects * Create writer file only if metrics are present (#23) * Create writer file only if metrics are present Signed-off-by: Sruti Parthiban <partsrut@amazon.com> * Add metrics to writers metric * Rename writer_file_creation metric name Signed-off-by: Sruti Parthiban <partsrut@amazon.com> * Update the statistic for the metric * Spotless changes Signed-off-by: Sruti Parthiban <partsrut@amazon.com> * Add privileges for removing files (#45) Signed-off-by: Sruti Parthiban <partsrut@amazon.com> * Remove spotless dependency on main (#54) This PR removes the need for the main branch to be checked out in order to build. Signed-off-by: Marc Handalian <handalm@amazon.com> * Upgrade to version 1.0.1 Co-authored-by: Khushboo Rajput <khushbr@amazon.com> Co-authored-by: Khushboo Rajput <59671881+khushbr@users.noreply.github.com> Co-authored-by: Marc Handalian <handalm@amazon.com>
eirsep
pushed a commit
to eirsep/performance-analyzer-rca
that referenced
this pull request
Sep 6, 2021
Signed-off-by: Sruti Parthiban <partsrut@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sruti Parthiban partsrut@amazon.com
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
#38
Describe the solution you are proposing
Calling the delete methods with privilege.
Tested by spinning up a docker and confirmed that files are cleaned as expected.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.