Skip to content

Add privileges for removing files #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sruti1312 merged 1 commit into from
Aug 17, 2021
Merged

Add privileges for removing files #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions ...ain/java/org/opensearch/performanceanalyzer/reader_writer_shared/EventLogFileHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,11 @@ private void readInternal(Path pathToFile, int bufferSize, EventDispatcher proce
}

public void deleteAllFiles() {
LOG.debug("Cleaning up any leftover files.");
Util.invokePrivileged(this::deleteAllFilesWithPrivilege);
}

public void deleteAllFilesWithPrivilege() {
LOG.debug("Cleaning up any leftover files in [{}]", metricsLocation);
File root = new File(metricsLocation);
String[] filesToDelete = root.list();
if (filesToDelete == null) {
Expand All @@ -202,7 +206,7 @@ public void deleteFiles(List<String> filesToDelete) {
File root = new File(metricsLocation);
for (String fileToDelete : filesToDelete) {
File file = new File(root, fileToDelete);
PerformanceAnalyzerMetrics.removeMetrics(file);
removeFilesWithPrivilege(file);
filesDeletedCount += 1;
}
long duration = System.currentTimeMillis() - startTime;
Expand All @@ -212,4 +216,8 @@ public void deleteFiles(List<String> filesToDelete) {
WriterMetrics.EVENT_LOG_FILES_DELETED, "", filesDeletedCount);
LOG.debug("'{}' Old writer files cleaned up.", filesDeletedCount);
}

public void removeFilesWithPrivilege(File file) {
Util.invokePrivileged(() -> PerformanceAnalyzerMetrics.removeMetrics(file));
}
}