Add log rotation and prevent noisy logs#87
Merged
kjoseph07 merged 1 commit intoopensearch-project:mainfrom Nov 9, 2021
kjoseph07:karisjos-logging-bug-fix
Merged
Add log rotation and prevent noisy logs#87kjoseph07 merged 1 commit intoopensearch-project:mainfrom kjoseph07:karisjos-logging-bug-fix
kjoseph07 merged 1 commit intoopensearch-project:mainfrom
kjoseph07:karisjos-logging-bug-fix
Conversation
Codecov Report
@@ Coverage Diff @@
## main #87 +/- ##
=========================================
Coverage 72.03% 72.03%
+ Complexity 2948 2947 -1
=========================================
Files 376 376
Lines 18723 18723
Branches 1432 1432
=========================================
Hits 13487 13487
Misses 4650 4650
Partials 586 586
Continue to review full report at Codecov.
|
sruti1312
previously approved these changes
Nov 9, 2021
Signed-off-by: Karishma Joseph <karisjos@amazon.com>
sruti1312
approved these changes
Nov 9, 2021
kjoseph07
added a commit
that referenced
this pull request
Nov 9, 2021
* Change main to 1.2 Signed-off-by: Karishma Joseph <karisjos@amazon.com> * Update README.md (#88) Signed-off-by: Sruti Parthiban <partsrut@amazon.com> * Add log rotation and prevent noisy logs (#87) Signed-off-by: Karishma Joseph <karisjos@amazon.com> Co-authored-by: Sruti Parthiban <partsrut@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Karishma Joseph karisjos@amazon.com
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
opensearch-project/performance-analyzer#80
#84
Describe the solution you are proposing
Rotate PerformanceAnalyzer.log and performance_analyzer_agent_stats.log files to avoid disk issue. Set the log level to debug (and not info) for the stats logs to prevent excessive noisy logs being piped to the console and opensearch.log file.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.