Skip to content

Add log rotation and prevent noisy logs #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kjoseph07 merged 1 commit into from
Nov 9, 2021
Merged

Add log rotation and prevent noisy logs #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 25 additions & 5 deletions pa_config/log4j2.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,34 @@
<Console name="Console" target="SYSTEM_OUT">
<PatternLayout pattern="%d{HH:mm:ss.SSS} [%t] %-5level %logger{36} - %msg%n" />
</Console>
<File name="PerformanceAnalyzerLog" fileName="/tmp/PerformanceAnalyzer.log" immediateFlush="true" append="true">
<RollingFile name="PerformanceAnalyzerLog" fileName="/tmp/PerformanceAnalyzer.log" filePattern="/tmp/PerformanceAnalyzer.log.%d{yyyy-MM-dd}-%i.gz" immediateFlush="true" append="true">
<PatternLayout pattern="%d{yyy-MM-dd HH:mm:ss.SSS} [PA:Reader] [%t] %-5level %logger{36} - %msg%n"/>
</File>
<File name="StatsLog" fileName="/tmp/performance_analyzer_agent_stats.log" immediateFlush="true" append="true">
</File>
<Policies>
<TimeBasedTriggeringPolicy interval="1" modulate="true"/>
<SizeBasedTriggeringPolicy size="128 MB"/>
</Policies>
<DefaultRolloverStrategy>
<Delete basePath="/tmp">
<IfFileName glob="PerformanceAnalyzer.log.*.gz" />
<IfAccumulatedFileSize exceeds="2 GB" />
</Delete>
</DefaultRolloverStrategy>
</RollingFile>
<RollingFile name="StatsLog" fileName="/tmp/performance_analyzer_agent_stats.log" filePattern="/tmp/performance_analyzer_agent_stats.log.%d{yyyy-MM-dd}-%i.gz" immediateFlush="true" append="true">
<Policies>
<TimeBasedTriggeringPolicy interval="1" modulate="true"/>
<SizeBasedTriggeringPolicy size="128 MB"/>
</Policies>
<DefaultRolloverStrategy>
<Delete basePath="/tmp">
<IfFileName glob="performance_analyzer_agent_stats.log.*.gz" />
<IfAccumulatedFileSize exceeds="2 GB" />
</Delete>
</DefaultRolloverStrategy>
</RollingFile>
</Appenders>
<Loggers>
<Logger name="stats_log" level="info" additivity="false">
<Logger name="stats_log" level="debug" additivity="false">
<AppenderRef ref="StatsLog"/>
</Logger>
<Root level="error">
Expand Down
4 changes: 3 additions & 1 deletion src/main/java/org/opensearch/performanceanalyzer/collectors/StatsCollector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,9 @@ private static void writeStats(

addEntry("Counters", getCountersString(counters), builder);
builder.append(LOG_ENTRY_END); // + LOG_LINE_BREAK);
STATS_LOGGER.info(builder.toString());
/* Setting this log level to debug (and not info) to avoid logging noisy plugin stats
logs to the console and opensearch.log file */
STATS_LOGGER.debug(builder.toString());
}

private static String getCountersString(Map<String, AtomicInteger> counters) {
Expand Down