Update REST resources to follow new OpenSearch naming convention#14
Merged
Update REST resources to follow new OpenSearch naming convention#14
Conversation
Plugin resources will appear under /_plugins instead of /_opendistro.
Codecov Report
@@ Coverage Diff @@
## main #14 +/- ##
============================================
+ Coverage 72.12% 72.21% +0.09%
- Complexity 339 348 +9
============================================
Files 43 44 +1
Lines 2461 2473 +12
Branches 150 155 +5
============================================
+ Hits 1775 1786 +11
- Misses 582 584 +2
+ Partials 104 103 -1
Continue to review full report at Codecov.
|
sruti1312
approved these changes
May 20, 2021
dblock
reviewed
May 21, 2021
| public static final String LOGGING_CONFIG_PATH = RestConfig.PA_BASE_URI + "/logging/config"; | ||
| public static final String BATCH_METRICS_CONFIG_PATH = RestConfig.PA_BASE_URI + "/batch/config"; | ||
|
|
||
| public static final String LEGACY_RCA_CONFIG_PATH = |
Member
There was a problem hiding this comment.
These LEGACY_PA_BASE_URI should really be LEGACY_OPENDISTRO_PA_BASE_URI. We weren't super clear in the doc, I fixed it in opensearch-project/opensearch-plugins#33.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugin resources will appear under
/_pluginsinstead of/_opendistro.Describe the solution you are proposing
Following the upgrade guide to rename our REST resources.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.