Refactor query shape field data maps#111
Merged
jainankitk merged 1 commit intoopensearch-project:mainfrom Sep 19, 2024
Merged
Conversation
20763f8 to
dc1e87a
Compare
jainankitk
reviewed
Sep 9, 2024
src/main/java/org/opensearch/plugin/insights/core/service/categorizer/QueryShapeGenerator.java
Outdated
Show resolved
Hide resolved
715e373 to
dc1e87a
Compare
deshsidd
reviewed
Sep 10, 2024
src/main/java/org/opensearch/plugin/insights/core/service/categorizer/QueryShapeGenerator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/plugin/insights/core/service/categorizer/QueryShapeGenerator.java
Outdated
Show resolved
Hide resolved
77e08c9 to
5c55429
Compare
Member
Author
|
Unrelated build failure fix: #117 |
030b5ef to
00c8f18
Compare
Member
Author
|
@jainankitk @deshsidd @ansjcy Please take a look again. Since all relevant builders now implement the |
jainankitk
reviewed
Sep 19, 2024
src/main/java/org/opensearch/plugin/insights/core/service/categorizer/QueryShapeGenerator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/plugin/insights/core/service/categorizer/QueryShapeGenerator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/plugin/insights/core/service/categorizer/QueryShapeGenerator.java
Outdated
Show resolved
Hide resolved
Signed-off-by: David Zane <davizane@amazon.com>
00c8f18 to
8539426
Compare
jainankitk
approved these changes
Sep 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactor query shape field data maps
With the introduction of
WithFieldNameinterface in OpenSearch core (see opensearch-project/OpenSearch#15705), we can now simplify the field data logic in Query-Insights.Issues Resolved
Resolves #109
Related RFC #69
Testing
Large Search
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.