Add toast handling for purge cache action#1824
Merged
DarshitChanpura merged 3 commits intoopensearch-project:mainfrom Mar 13, 2024
Merged
Add toast handling for purge cache action#1824DarshitChanpura merged 3 commits intoopensearch-project:mainfrom
DarshitChanpura merged 3 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Derek Ho <dxho@amazon.com>
derek-ho
commented
Mar 12, 2024
Signed-off-by: Derek Ho <dxho@amazon.com>
derek-ho
requested review from
DarshitChanpura,
RyanL1997,
cliu123,
cwperks,
davidlago,
peternied and
stephen-crawford
as code owners
Signed-off-by: Derek Ho <dxho@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1824 +/- ##
==========================================
+ Coverage 67.38% 67.52% +0.13%
==========================================
Files 94 94
Lines 2410 2414 +4
Branches 320 327 +7
==========================================
+ Hits 1624 1630 +6
+ Misses 708 706 -2
Partials 78 78 ☔ View full report in Codecov by Sentry. |
cwperks
approved these changes
Mar 12, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 13, 2024
(cherry picked from commit 942b2f7)
cwperks
pushed a commit
that referenced
this pull request
Mar 13, 2024
3 tasks
3 tasks
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a toast message for success and failure of the purge cache action.
Category
[Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation]
Enhancement
Why these changes are required?
Today, there is no indication that a purge cache action succeeded or failed. This can be confusing to the user as they would not know the result unless they have the network tab open or are checking the backend logs. This adds visual indication and brings this action more inline with other actions such as create user. This also acts as a shim for end to end testing which can rely on the new toast to see if some action succeeded or failed.
What is the old behavior before changes and new behavior after changes?
New behavior shown below:
Screen.Recording.2024-03-12.at.2.10.44.PM.mov
Issues Resolved
[List any issues this PR will resolve (Is this a backport? If so, please add backport PR # and/or commits #)]
Fix: #1815
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Manual testing, added tests
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.