Adding @derek-ho as a maintainer#1842
Merged
DarshitChanpura merged 2 commits intoopensearch-project:mainfrom Mar 26, 2024
Merged
Adding @derek-ho as a maintainer#1842DarshitChanpura merged 2 commits intoopensearch-project:mainfrom
DarshitChanpura merged 2 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Craig Perkins <cwperx@amazon.com>
DarshitChanpura
approved these changes
Mar 21, 2024
Member
DarshitChanpura
left a comment
There was a problem hiding this comment.
Welcome aboard @derek-ho !
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1842 +/- ##
=======================================
Coverage 68.04% 68.04%
=======================================
Files 94 94
Lines 2422 2422
Branches 330 330
=======================================
Hits 1648 1648
Misses 696 696
Partials 78 78 ☔ View full report in Codecov by Sentry. |
stephen-crawford
approved these changes
Mar 22, 2024
RyanL1997
approved these changes
Mar 23, 2024
peternied
approved these changes
Mar 26, 2024
Member
|
We have approvals from all maintainers. |
Member
|
@cwperks Could you update the code owners file and then ask the admin team to make the settings change on the repo? |
Member
Author
|
@peternied TY, I opened a PR to add @derek-ho to CODEOWNERS. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
@derek-ho has been an avid contributor to the security-dashboards-plugin repo since June '23 with 19 Pull Requests merged into main to date. Derek regularly engages on Pull Requests by giving other contributors valuable feedback, helps to maintain all release branches with critical bug fixes and ensuring dependencies are free of known security vulnerabilities, and contributes new features to the security-dashboards-plugin. Some of @derek-ho's notable contributions include:
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.