Skip to content

[CI] Fix windows integ test workflow#2308

Merged
DarshitChanpura merged 2 commits intoopensearch-project:mainfrom
DarshitChanpura:windows-integ-test-fix
Sep 12, 2025
Merged

[CI] Fix windows integ test workflow#2308
DarshitChanpura merged 2 commits intoopensearch-project:mainfrom
DarshitChanpura:windows-integ-test-fix

Conversation

@DarshitChanpura
Copy link
Copy Markdown
Member

@DarshitChanpura DarshitChanpura commented Sep 11, 2025

Description

Fixes windows path issue when reading security plugin zip for installation in integration test workflow.

Category

Maintenance

Why these changes are required?

Unblocks CI

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
@DarshitChanpura DarshitChanpura changed the title [Bug Fix] Fix windows integ test workflow Fix windows integ test workflow Sep 11, 2025
@DarshitChanpura DarshitChanpura changed the title Fix windows integ test workflow [CI] Fix windows integ test workflow Sep 11, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.96%. Comparing base (36fe977) to head (4076093).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2308   +/-   ##
=======================================
  Coverage   71.96%   71.96%           
=======================================
  Files          98       98           
  Lines        2679     2679           
  Branches      409      417    +8     
=======================================
  Hits         1928     1928           
  Misses        637      637           
  Partials      114      114           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
@cwperks
Copy link
Copy Markdown
Member

cwperks commented Sep 12, 2025

@DarshitChanpura can we borrow the same fix from #2307 (comment)?

@DarshitChanpura
Copy link
Copy Markdown
Member Author

it uses similar concept, except instead of replacing with regex, it simply uses Join-Path and System.Uri.

It is extract into a common step because two clusters are started here compare to 1 in the backend fix. We can keep this change.

@DarshitChanpura DarshitChanpura marked this pull request as ready for review September 12, 2025 15:20
@DarshitChanpura DarshitChanpura merged commit 5724b8e into opensearch-project:main Sep 12, 2025
26 checks passed
@DarshitChanpura DarshitChanpura deleted the windows-integ-test-fix branch September 12, 2025 17:32
@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

The backport to 2.19 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security-dashboards-plugin/backport-2.19 2.19
# Navigate to the new working tree
pushd ../.worktrees/security-dashboards-plugin/backport-2.19
# Create a new branch
git switch --create backport/backport-2308-to-2.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5724b8e388013d8cf665704f7a661e09c54b64da
# Push it to GitHub
git push --set-upstream origin backport/backport-2308-to-2.19
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security-dashboards-plugin/backport-2.19

Then, create a pull request where the base branch is 2.19 and the compare/head branch is backport/backport-2308-to-2.19.

@cwperks
Copy link
Copy Markdown
Member

cwperks commented Sep 12, 2025

@DarshitChanpura does this need to be backported to 2.19?

@DarshitChanpura
Copy link
Copy Markdown
Member Author

Don't think so CI seems to be running on java 11 for 2.19 so it should be fine, right?

@cwperks
Copy link
Copy Markdown
Member

cwperks commented Sep 12, 2025

Yes you are right, it is a java version issue. I tried with 17 on opensearch-project/security#5621 and it failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants