[CI] Fix windows integ test workflow#2308
[CI] Fix windows integ test workflow#2308DarshitChanpura merged 2 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2308 +/- ##
=======================================
Coverage 71.96% 71.96%
=======================================
Files 98 98
Lines 2679 2679
Branches 409 417 +8
=======================================
Hits 1928 1928
Misses 637 637
Partials 114 114 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
99e05ea to
4076093
Compare
|
@DarshitChanpura can we borrow the same fix from #2307 (comment)? |
|
it uses similar concept, except instead of replacing with regex, it simply uses Join-Path and System.Uri. It is extract into a common step because two clusters are started here compare to 1 in the backend fix. We can keep this change. |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security-dashboards-plugin/backport-2.19 2.19
# Navigate to the new working tree
pushd ../.worktrees/security-dashboards-plugin/backport-2.19
# Create a new branch
git switch --create backport/backport-2308-to-2.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5724b8e388013d8cf665704f7a661e09c54b64da
# Push it to GitHub
git push --set-upstream origin backport/backport-2308-to-2.19
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security-dashboards-plugin/backport-2.19Then, create a pull request where the |
|
@DarshitChanpura does this need to be backported to 2.19? |
|
Don't think so CI seems to be running on java 11 for 2.19 so it should be fine, right? |
|
Yes you are right, it is a java version issue. I tried with 17 on opensearch-project/security#5621 and it failed. |
Description
Fixes windows path issue when reading security plugin zip for installation in integration test workflow.
Category
Maintenance
Why these changes are required?
Unblocks CI
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.