Skip to content

Fix UnboundLocalError in update_etc_hosts #2797

Open
eliajahshan wants to merge 1 commit intoopenshift:masterfrom
eliajahshan:ipv6_dual
Open

Fix UnboundLocalError in update_etc_hosts #2797
eliajahshan wants to merge 1 commit intoopenshift:masterfrom
eliajahshan:ipv6_dual

Conversation

@eliajahshan
Copy link
Copy Markdown
Contributor

when all DNS entries already exist

The log.info referenced 'ip' and 'dns_name' variables that were only bound inside for-loops. When all entries in dns_map were already present in /etc/hosts, the second loop iterated over an empty dict, leaving the variables unbound and crashing with UnboundLocalError.

Snapshot dns_map before mutation and log all entries after writing.

…y exist

The log.info referenced 'ip' and 'dns_name' variables that were only
bound inside for-loops. When all entries in dns_map were already present
in /etc/hosts, the second loop iterated over an empty dict, leaving
the variables unbound and crashing with UnboundLocalError.

Snapshot dns_map before mutation and log all entries after writing.
@openshift-ci openshift-ci bot requested review from danmanor and rccrdpccl March 12, 2026 14:01
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 12, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: eliajahshan
Once this PR has been reviewed and has the lgtm label, please assign rccrdpccl for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 12, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 12, 2026

Hi @eliajahshan. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant