Skip to content

Fix UnboundLocalError in update_etc_hosts #2797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eliajahshan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix UnboundLocalError in update_etc_hosts #2797

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/assisted_test_infra/test_infra/utils/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,6 +387,9 @@ def update_etc_hosts(dns_map: dict[str, str]) -> None:
lock_file = "/tmp/test_etc_hosts.lock"

with file_lock_context(lock_file):
# Snapshot all entries for logging before dns_map gets mutated
all_entries = dict(dns_map)

with open("/etc/hosts", "r") as f:
hosts_lines = f.readlines()

Expand All @@ -403,6 +406,8 @@ def update_etc_hosts(dns_map: dict[str, str]) -> None:

with open("/etc/hosts", "w") as f:
f.writelines(hosts_lines)

for dns_name, ip in all_entries.items():
log.info("Updated /etc/hosts with record: %s %s", ip, dns_name)


Expand Down