Remove rhel-9-openstack-17-rpms from base rhel9 repo files#76590
Remove rhel-9-openstack-17-rpms from base rhel9 repo files#76590elfosardo wants to merge 1 commit intoopenshift:mainfrom
Conversation
|
/hold |
a5973b7 to
ecac380
Compare
|
/unhold |
|
/pj-rehearse pull-ci-openshift-origin-release-4.18-images pull-ci-openshift-origin-release-4.19-images pull-ci-openshift-origin-release-5.0-images pull-ci-openshift-origin-release-4.23-images pull-ci-openshift-origin-release-4.22-images pull-ci-openshift-origin-release-4.21-images pull-ci-openshift-origin-release-4.16-images pull-ci-openshift-origin-main-images pull-ci-openshift-origin-release-4.20-images pull-ci-openshift-origin-release-4.17-images |
|
@elfosardo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
The rhel-9-openstack-17-rpms repository was included in the base
ocp-*-rhel9.repo files, making OpenStack 17 packages available to
all rhel9-based image builds. This is unnecessary for most images
and should be opt-in, similar to how ironic repos are handled.
The packages in the OpenStack 17 repo are old and outdated at this
point, so having them enabled by default for every rhel9 image
build adds unnecessary exposure to stale dependencies without any
benefit to the vast majority of images.
The separate ocp-*-openstack.repo files already exist for all
affected versions (4.16-4.23, 5.0) and are served by their own
content-mirror services (base-openstack-4-Y.ocp.svc).
Images that need OpenStack 17 packages should use a
pipeline_image_cache_step to inject the openstack repo, following
the same pattern used by ironic-image. For example, in a
ci-operator config for OCP 4.22:
raw_steps:
- pipeline_image_cache_step:
commands: |
curl http://base-openstack-4-22.ocp.svc > /etc/yum.repos.art/ci/base-openstack-4-22.repo
from: tools
to: tools-openstack
Then use "tools-openstack" as the "from:" in your image build
definition instead of "tools".
The openshift/origin CI configs are updated here as an example of
this pattern, since the origin tests image is the only known
consumer of the openstack repo in the production pipeline.
See ci-operator/config/openshift/ironic-image/ for another working
example of this pattern with the ironic repos.
ecac380 to
12bbb57
Compare
|
/pj-rehearse pull-ci-openshift-origin-release-4.18-images pull-ci-openshift-origin-release-4.19-images pull-ci-openshift-origin-release-5.0-images pull-ci-openshift-origin-release-4.23-images pull-ci-openshift-origin-release-4.22-images pull-ci-openshift-origin-release-4.21-images pull-ci-openshift-origin-release-4.16-images pull-ci-openshift-origin-main-images pull-ci-openshift-origin-release-4.20-images pull-ci-openshift-origin-release-4.17-images |
|
@elfosardo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
A total of 764 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: elfosardo, joepvd The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@elfosardo: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The rhel-9-openstack-17-rpms repository was included in the base
ocp-*-rhel9.repo files, making OpenStack 17 packages available to
all rhel9-based image builds. This is unnecessary for most images
and should be opt-in, similar to how ironic repos are handled.
The packages in the OpenStack 17 repo are old and outdated at this
point, so having them enabled by default for every rhel9 image
build adds unnecessary exposure to stale dependencies without any
benefit to the vast majority of images.
The separate ocp-*-openstack.repo files already exist for all
affected versions (4.16-4.23, 5.0) and are served by their own
content-mirror services (base-openstack-4-Y.ocp.svc).
Images that need OpenStack 17 packages should use a
pipeline_image_cache_step to inject the openstack repo, following
the same pattern used by ironic-image. For example, in a
ci-operator config for OCP 4.22:
raw_steps:
commands: |
curl http://base-openstack-4-22.ocp.svc/ > /etc/yum.repos.art/ci/base-openstack-4-22.repo
from: tools
to: tools-openstack
Then use "tools-openstack" as the "from:" in your image build
definition instead of "tools".
The openshift/origin CI configs are updated here as an example of
this pattern, since the origin tests image is the only known
consumer of the openstack repo in the production pipeline.
See ci-operator/config/openshift/ironic-image/ for another working
example of this pattern with the ironic repos.