fix(block): 新建区块保存后发布区块，发布无效 #438
Conversation
chilingling
force-pushed
the
fix/release-block-not-responding
branch
from
c7c45e5 to
fe33535
Compare
|
Warning Rate limit exceeded@chilingling has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 26 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe changes in this pull request focus on the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
packages/common/component/BlockDeployDialog.vue (1)
Line range hint
166-171: Add error handling when bothgetEditBlock()anduseBlock().getCurrentBlock()return nullCurrently, if both
getEditBlock()anduseBlock().getCurrentBlock()return null or undefined,blockwill be null, which may cause errors when callingpublishBlock(params). It's advisable to add error handling to manage this scenario and provide feedback to the user.Apply this diff to add error handling:
const deployBlock = async () => { deployBlockRef.value.validate((valid) => { const { PLUGIN_NAME, getPluginApi } = useLayout() const { getEditBlock, publishBlock } = getPluginApi(PLUGIN_NAME.BlockManage) if (valid) { const block = getEditBlock() || useBlock().getCurrentBlock() + if (!block) { + useNotify({ + type: 'error', + message: '无法获取当前区块，发布失败' + }) + return + } const params = { block: block, is_compile: true, deploy_info: formState.deployInfo, version: formState.version, needToSave: formState.needToSave } publishBlock(params) setVisible(false) formState.deployInfo = '' formState.version = '' formState.needToSave = true } }) }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- packages/common/component/BlockDeployDialog.vue (3 hunks)
🔇 Additional comments (1)
packages/common/component/BlockDeployDialog.vue (1)
85-85:useBlockimport added appropriatelyThe addition of
useBlockin the import statement is correct and necessary for accessing the current block in the updated logic.
* fix(block): 新建区块保存后发布区块，发布无效 * fix: del useless null check --------- Co-authored-by: chilingling <michaelchiling1024@gmail.com>
* fix(block): 新建区块保存后发布区块，发布无效 * fix: del useless null check --------- Co-authored-by: chilingling <michaelchiling1024@gmail.com>
3 participants
English | 简体中文
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Background and solution
What is the current behavior?
新建区块发布失败，发布时获取区块schema为空
Issue Number: N/A
What is the new behavior?
新建区块发布成功，发布时可正常获取区块schema
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
New Features
Bug Fixes