Make sure there's room for the full alert id in json alerts#1487
Merged
atomicturtle merged 1 commit intoossec:masterfrom Aug 6, 2018
Merged
Make sure there's room for the full alert id in json alerts#1487atomicturtle merged 1 commit intoossec:masterfrom
atomicturtle merged 1 commit intoossec:masterfrom
Conversation
When writing rule id in json alerts file, the id is truncated and can be non unique, on intensive alerts generation. This is due snprintf buffer size which is too small to store id. Indeed id is composed of two long int (timestamp and log offset) then the size can be to 21 characters (10 digits for both timestamp and offset + the dot) The fix set id buffer to the correct size, and snprintf max size. wazuh/wazuh#1052 I'm not positive this affects us, but it probably doesn't hurt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From gandalfn in wazuh pull request #1052: