Skip to content

[enhancement]: hictk balance: improve log messages when balancing with --mode=trans#476

Open
robomics wants to merge 1 commit intomainfrom
feat/hictk-balance-logging
Open

[enhancement]: hictk balance: improve log messages when balancing with --mode=trans#476
robomics wants to merge 1 commit intomainfrom
feat/hictk-balance-logging

Conversation

@robomics
Copy link
Contributor

No description provided.

@robomics robomics added the enhancement New feature or request label Nov 14, 2025
@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

❌ Patch coverage is 68.05556% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.30%. Comparing base (4730173) to head (88db510).

Files with missing lines Patch % Lines
...alancing/include/hictk/balancing/impl/ice_impl.hpp 76.31% 6 Missing and 3 partials ⚠️
...ancing/include/hictk/balancing/impl/scale_impl.hpp 58.82% 5 Missing and 2 partials ⚠️
...balancing/include/hictk/balancing/impl/vc_impl.hpp 58.82% 5 Missing and 2 partials ⚠️

❌ Your patch check has failed because the patch coverage (68.05%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #476      +/-   ##
==========================================
- Coverage   81.37%   81.30%   -0.07%     
==========================================
  Files         184      184              
  Lines       18802    18832      +30     
  Branches     2622     2622              
==========================================
+ Hits        15300    15312      +12     
- Misses       2610     2624      +14     
- Partials      892      896       +4     
Flag Coverage Δ
[tests fuzzer](https://app.codecov.io/gh/paulsengroup/hictk/pull/476/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup) 30.28% <ø> (+<0.01%)
[tests integration](https://app.codecov.io/gh/paulsengroup/hictk/pull/476/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup) 71.09% <68.05%> (-0.05%)
[tests unittests](https://app.codecov.io/gh/paulsengroup/hictk/pull/476/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup) 79.55% <68.05%> (-0.12%)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant