Properly Support RETURNS TABLE (T) (returning a table with 1 field)#1164
Merged
eeeebbbbrrrr merged 1 commit intodevelopfrom Jun 8, 2023
Merged
Properly Support RETURNS TABLE (T) (returning a table with 1 field)#1164eeeebbbbrrrr merged 1 commit intodevelopfrom
RETURNS TABLE (T) (returning a table with 1 field)#1164eeeebbbbrrrr merged 1 commit intodevelopfrom
Conversation
Postgres treats a SRF that returns a 1-field table as if it is a `RETURNS SETOF T`, so we need to do that too. This adds a standalone function in the `srf` example, and a few tests that ensure this also works when returning it wrapped in `Result` or `Option` (or both!)
thomcc
approved these changes
Jun 8, 2023
Contributor
thomcc
left a comment
thomcc
left a comment
There was a problem hiding this comment.
Seems fine, this code continues to be gnarly as hell, but that's how it is I suppose.
Contributor
Author
Yeah. It's pretty much at the point where some considered design needs to happen before we start overloading it with more functionality. |
BradyBonnette
approved these changes
Jun 8, 2023
This was referenced Jun 8, 2023
usamoi
pushed a commit
to tensorchord/pgrx
that referenced
this pull request
Mar 6, 2025
…pgcentralfoundation#1164) Postgres treats a SRF that returns a 1-field table as if it is a `RETURNS SETOF T`, so we need to do that too. This adds a standalone function in the `srf` example, and a few tests that ensure this also works when returning it wrapped in `Result` or `Option` (or both!)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Postgres treats a SRF that returns a 1-field table as if it is a
RETURNS SETOF T, so we need to do that too.This adds a standalone function in the
srfexample, and a few tests that ensure this also works when returning it wrapped inResultorOption(or both!)