Support RETURNS TABLE (...) functions#326
Merged
eeeebbbbrrrr merged 10 commits intodevelopfrom Jun 8, 2023
Merged
Conversation
…nd I'll provide more details in the PR
- docs for SRF functions in general
- add a test for returning a 1 column table, which we expect to fail right now.
BradyBonnette
approved these changes
Jun 8, 2023
Contributor
BradyBonnette
left a comment
There was a problem hiding this comment.
Looks good, if more changes are needed lmk!
Contributor
Author
|
I'm gonna hold this until we get pgcentralfoundation/pgrx#1164 over in pgrx merged and released. This PR will need a test around returning a table with 1 field, which is blocked on that pgrx PR right now. |
… just keep doing that going forward
Contributor
Author
Done. Added the dependency updates to this PR too, since it needs them. Once CI passes I'm gonna merge. |
This was referenced Jun 9, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR gets support for set returning functions. It needs tests and another once over, but this little sql works now: