Compiler: stop playing notification pingpong#13047
Compiler: stop playing notification pingpong#13047MarcusDenker merged 9 commits intopharo-project:Pharo12from
Conversation
…laredVariableWarning
|
Great. You see this is a legacy from the "interactive" view of the world. |
|
Tests failed because of a single test in NewTools. Not nice. I do not want to add a buggy workaround here in compiler (like identifying the specific requestor or test) so I should fix the test in the other repository. |
|
Sure! We should target all green tests else it will block us for no reason. |
|
Test does not seem really fixable now, so I propose to simply skip it pharo-spec/NewTools#492. |
|
Very nice... such a huge step to be able to remove ReparseAfterSourceEditing! |
Big step, but I tried to make it as small and simple as possible for testability and reviewability (especially commit by commit).
Up to now, automatic (mandatory!) code reparation on compilation error (the "undefined variable foo, please do something or cancel" menu) is managed through a complex exceptions mess and badly designed responsibility assignment.
Unfortunately, getting rid of it is less easy as it seems (and it seems hard!)
This PR does the main part of the cleanup:
parseForRequestor(still bad, but much less bad)OCUndeclaredVariableWarningstops opening the menu by itself as default action. All that remains is the console warning for CI.parseForRequestorcatchesOCUndeclaredVariableWarninginstead ofReparseAfterSourceEditing, open the menu, and retry the parsing all by itself (previously it was done byOCUndeclaredVariableWarning)ReparseAfterSourceEditingis removedReparseAfterSourceEditingis removedWhat is not done and let for future PR
OCUndeclaredVariableWarningOCSemanticWarningparseForRequestorfor good