skip testDoEvaluateDeclareGlobal for now#492
Merged
jecisc merged 1 commit intopharo-spec:Pharo11from Mar 18, 2023
Merged
Conversation
jecisc
approved these changes
Mar 18, 2023
Member
jecisc
left a comment
jecisc
left a comment
There was a problem hiding this comment.
The compiler cleanup are really nice, it's worth to disable this test for a while (especially since it does not impact P11)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test tries to hijack low-level compiler stuff. This break PR to improve stuff: pharo-project/pharo#13047
So disable it for now, we will try to enable it back (or in a better form) during Pharo 12 dev cycle (we are very early in the cycle, so it's doable).