Skip to content

Expose LogLevel param for x264 codec #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hexbabe wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Expose LogLevel param for x264 codec #685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d0b849
Suppress noisy x264 [info] log messages and expose LogLevel param
hexbabe Feb 11, 2026
e389232
Default to info to avoid breaking change; Fix comment
hexbabe Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/codec/x264/bridge.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ Encoder *enc_new(x264_param_t param, char *preset, int *rc) {
free(preset);

/* Configure non-default params */
e->param.i_log_level = param.i_log_level;
e->param.i_csp = param.i_csp;
e->param.i_width = param.i_width;
e->param.i_height = param.i_height;
Expand Down
22 changes: 22 additions & 0 deletions pkg/codec/x264/params.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,29 @@ type Params struct {

// Faster preset has lower CPU usage but lower quality
Preset Preset

// LogLevel controls the verbosity of x264's internal logging.
// Messages at this level and above severities will be emitted.
// Defaults to LogInfo to match x264's default behavior.
LogLevel LogLevel
}

// LogLevel controls which x264 log messages are emitted.
type LogLevel int

const (
// LogNone suppresses all log output from x264.
LogNone LogLevel = iota
// LogError shows only error messages.
LogError
// LogWarning shows warnings and errors.
LogWarning
// LogInfo shows info, warnings, and errors (x264 default).
LogInfo
// LogDebug shows all messages including debug output.
LogDebug
)

// Preset represents a set of default configurations from libx264
type Preset int

Expand All @@ -36,6 +57,7 @@ func NewParams() (Params, error) {
BaseParams: codec.BaseParams{
KeyFrameInterval: 60,
},
LogLevel: LogInfo,
}, nil
}

Expand Down
18 changes: 18 additions & 0 deletions pkg/codec/x264/x264.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,11 +72,29 @@ func newEncoder(r video.Reader, p prop.Media, params Params) (codec.ReadCloser,
// Reference: https://code.videolan.org/videolan/x264/-/blob/7923c5818b50a3d8816eed222a7c43b418a73b36/encoder/ratecontrol.c#L657
params.BitRate /= 1000

// Map Go LogLevel to x264 log level constants.
// x264 uses: X264_LOG_NONE(-1), X264_LOG_ERROR(0), X264_LOG_WARNING(1),
// X264_LOG_INFO(2), X264_LOG_DEBUG(3).
x264LogLevel := C.int(C.X264_LOG_INFO)
switch params.LogLevel {
case LogNone:
x264LogLevel = C.X264_LOG_NONE
case LogError:
x264LogLevel = C.X264_LOG_ERROR
case LogWarning:
x264LogLevel = C.X264_LOG_WARNING
case LogInfo:
x264LogLevel = C.X264_LOG_INFO
case LogDebug:
x264LogLevel = C.X264_LOG_DEBUG
}

param := C.x264_param_t{
i_csp: C.X264_CSP_I420,
i_width: C.int(p.Width),
i_height: C.int(p.Height),
i_keyint_max: C.int(params.KeyFrameInterval),
i_log_level: x264LogLevel,
}
param.rc.i_bitrate = C.int(params.BitRate)
param.rc.i_vbv_max_bitrate = param.rc.i_bitrate
Expand Down
Loading