Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #685 +/- ##
=======================================
Coverage 42.13% 42.13%
=======================================
Files 86 86
Lines 5186 5200 +14
=======================================
+ Hits 2185 2191 +6
- Misses 2839 2847 +8
Partials 162 162 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4 tasks
hexbabe
changed the title
hexbabe
changed the title
x264's default log level (X264_LOG_INFO) causes it to write encoder stats, CPU capabilities, and profile info to stderr. When used with viam-server, these appear as warn-level logs and create noise. Default to LogWarning to suppress info messages while preserving actual warnings and errors. Expose a LogLevel field on Params so consumers can control the verbosity themselves. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
hexbabe
force-pushed
the
hexbabe/RSDK-12315-x264-log-level
branch
from
b352a90 to
e389232
Compare
hexbabe
requested review from
JoTurk,
at-wat and
philipch07
and removed request for
at-wat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LogLevelfield tox264.Paramsso consumers can control x264 log verbosity (None, Error, Warning, Info, Debug), with default beingX264_LOG_WARNINGThis PR is separate from the
x/3stacked PRs for windows.Test plan
[info]messages no longer appear in stderr with default paramsLogLevel: x264.LogInforestores original verbose behavior🤖 Generated with Claude Code, verified by me