Skip to content

[RelayMiner] Improve non-2xx errors visibility, do not mine 5xx#1695

Merged
red-0ne merged 7 commits intomainfrom
feat/improve-non-2xx-logs
Aug 4, 2025
Merged

[RelayMiner] Improve non-2xx errors visibility, do not mine 5xx#1695
red-0ne merged 7 commits intomainfrom
feat/improve-non-2xx-logs

Conversation

@red-0ne
Copy link
Copy Markdown
Contributor

@red-0ne red-0ne commented Jul 28, 2025

Summary

Enhance error logging for non-2xx HTTP responses and prevent 5xx server errors from entering the reward pipeline

Primary Changes:

  • Add detailed logging for non-2xx responses including request_url, request payload snippets, and response payload snippets for better debugging
  • Prevent 5xx server errors from entering the reward pipeline to avoid rewarding failed backend services
  • Refactor response serialization to occur before error logging for consistent payload access

Secondary changes:

  • Improve code comments for clarity on reward eligibility conditions
  • Reorganize response handling flow for better error visibility

Issue:

Problem: Non-2xx HTTP responses lacked sufficient debugging information and 5xx server errors were incorrectly entering the reward pipeline, potentially rewarding failed backend services.

Type of change

Select one or more from the following:

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

Sanity Checklist

  • I have updated the GitHub Issue Metadata: assignees, reviewers, labels, project, iteration and milestone
  • For docs: make docusaurus_start
  • For small changes: make go_develop_and_test and make test_e2e
  • For major changes: devnet-test-e2e label to run E2E tests in CI
  • For migration changes: make test_e2e_oneshot
  • 'TODO's, configurations and other docs

red-0ne and others added 3 commits July 28, 2025 20:51
## A handful of random misc changes

- Fix the release telegram bot
- Improve telegram helpers in `makefiles/telegram.mk`
- Update `tools/scripts/params/bulk_params_beta/tokenomics_params.json` in prep for tokenomics changes
- Update gov param docs
@red-0ne red-0ne self-assigned this Jul 28, 2025
@red-0ne red-0ne added relayminer Changes related to the Relayminer proxy Changes related to the Proxy off-chain Off-chain business logic labels Jul 28, 2025
@red-0ne red-0ne added this to Shannon Jul 28, 2025
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Shannon Jul 28, 2025
@red-0ne red-0ne moved this from 📋 Backlog to 👀 In review in Shannon Jul 28, 2025
@red-0ne red-0ne requested a review from Olshansk July 28, 2025 18:57
@red-0ne red-0ne changed the title feat: Improve non-2xx errors visibility, do not mine 5xx [RelayMiner] Improve non-2xx errors visibility, do not mine 5xx Jul 28, 2025
@red-0ne red-0ne requested a review from Olshansk July 31, 2025 16:51
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 4, 2025

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks.

You may need to run make trigger_ci to submit an empty commit that'll trigger the tests.

GCP workloads (requires changing the namespace to 1695)
Grafana network dashboard for devnet-issue-1695

@github-actions github-actions bot added devnet push-image CI related - pushes images to ghcr.io labels Aug 4, 2025
@red-0ne red-0ne merged commit aca2f69 into main Aug 4, 2025
10 of 11 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Shannon Aug 4, 2025
bryanchriswhite added a commit that referenced this pull request Aug 15, 2025
* pokt/main: (34 commits)
  [GOVERNANCE][PARAMS][CUTTM] Updating global CUTTM per Foundation requirement (#1727)
  Update docusaurus/docs/4_develop/upgrades/4_upgrade_list.md w/ v0.1.28 MainNet block
  Updating bulk_params_main/tokenomics_params.json so proposer gets rewards again
  Update upgrade_tx_v0.1.28_main.json
  [Morse Recovery] Add recovery allowlist entries for issues #1718 and #1719 (#1723)
  [Upgrade]: Update v0.1.28 upgrade list docs (#1722)
  [Upgrade] v0.1.28 upgrade txs (#1721)
  [Upgrade] Add v0.1.28 upgrade plan (#1720)
  [CometBFT] Use Pocket's fork temporarily (#1717)
  Use use_cometbft_fork_v038.17 (#1714)
  [RelayMiner] Add session lifetime caching (#1713)
  Update recovery allowlist for recovery-8aug2025 (#1716)
  [Tokenomics] Validator proper decoding (#1710)
  [Session Rollovers] First attempt at solving session rollovers from RelayMiner's POV (#1705)
  [RelayMiner] Add comprehensive relay timing and gRPC call metrics (#1703)
  [Shared Module] Increase `ComputeUnitsPerRelayMax` (#1709)
  [RelayMiner] Improve non-2xx errors visibility, do not mine 5xx (#1695)
  [Governance] - Updated Params to match the ones in the forum  (#1707)
  [RelayMiner] Improve RelayMiner timeout handling and test reliability (#1691)
  [Morse Recovery] Updated Allowlist for Recovery (#1696)
  ...
bryanchriswhite added a commit that referenced this pull request Aug 15, 2025
* chore/localnet/tilt: (36 commits)
  [GOVERNANCE][PARAMS][CUTTM] Updating global CUTTM per Foundation requirement (#1727)
  Update docusaurus/docs/4_develop/upgrades/4_upgrade_list.md w/ v0.1.28 MainNet block
  Updating bulk_params_main/tokenomics_params.json so proposer gets rewards again
  Update upgrade_tx_v0.1.28_main.json
  [Morse Recovery] Add recovery allowlist entries for issues #1718 and #1719 (#1723)
  [Upgrade]: Update v0.1.28 upgrade list docs (#1722)
  [Upgrade] v0.1.28 upgrade txs (#1721)
  [Upgrade] Add v0.1.28 upgrade plan (#1720)
  [CometBFT] Use Pocket's fork temporarily (#1717)
  Use use_cometbft_fork_v038.17 (#1714)
  [RelayMiner] Add session lifetime caching (#1713)
  Update recovery allowlist for recovery-8aug2025 (#1716)
  [Tokenomics] Validator proper decoding (#1710)
  [Session Rollovers] First attempt at solving session rollovers from RelayMiner's POV (#1705)
  [RelayMiner] Add comprehensive relay timing and gRPC call metrics (#1703)
  [Shared Module] Increase `ComputeUnitsPerRelayMax` (#1709)
  [RelayMiner] Improve non-2xx errors visibility, do not mine 5xx (#1695)
  [Governance] - Updated Params to match the ones in the forum  (#1707)
  [RelayMiner] Improve RelayMiner timeout handling and test reliability (#1691)
  [Morse Recovery] Updated Allowlist for Recovery (#1696)
  ...

# Conflicts:
#	tiltfiles/ibc.tilt
bryanchriswhite added a commit that referenced this pull request Aug 15, 2025
* refs/heads/chore/ibc-axelar: (36 commits)
  [GOVERNANCE][PARAMS][CUTTM] Updating global CUTTM per Foundation requirement (#1727)
  Update docusaurus/docs/4_develop/upgrades/4_upgrade_list.md w/ v0.1.28 MainNet block
  Updating bulk_params_main/tokenomics_params.json so proposer gets rewards again
  Update upgrade_tx_v0.1.28_main.json
  [Morse Recovery] Add recovery allowlist entries for issues #1718 and #1719 (#1723)
  [Upgrade]: Update v0.1.28 upgrade list docs (#1722)
  [Upgrade] v0.1.28 upgrade txs (#1721)
  [Upgrade] Add v0.1.28 upgrade plan (#1720)
  [CometBFT] Use Pocket's fork temporarily (#1717)
  Use use_cometbft_fork_v038.17 (#1714)
  [RelayMiner] Add session lifetime caching (#1713)
  Update recovery allowlist for recovery-8aug2025 (#1716)
  [Tokenomics] Validator proper decoding (#1710)
  [Session Rollovers] First attempt at solving session rollovers from RelayMiner's POV (#1705)
  [RelayMiner] Add comprehensive relay timing and gRPC call metrics (#1703)
  [Shared Module] Increase `ComputeUnitsPerRelayMax` (#1709)
  [RelayMiner] Improve non-2xx errors visibility, do not mine 5xx (#1695)
  [Governance] - Updated Params to match the ones in the forum  (#1707)
  [RelayMiner] Improve RelayMiner timeout handling and test reliability (#1691)
  [Morse Recovery] Updated Allowlist for Recovery (#1696)
  ...
bryanchriswhite added a commit that referenced this pull request Aug 15, 2025
* docs/ibc/localnet: (36 commits)
  [GOVERNANCE][PARAMS][CUTTM] Updating global CUTTM per Foundation requirement (#1727)
  Update docusaurus/docs/4_develop/upgrades/4_upgrade_list.md w/ v0.1.28 MainNet block
  Updating bulk_params_main/tokenomics_params.json so proposer gets rewards again
  Update upgrade_tx_v0.1.28_main.json
  [Morse Recovery] Add recovery allowlist entries for issues #1718 and #1719 (#1723)
  [Upgrade]: Update v0.1.28 upgrade list docs (#1722)
  [Upgrade] v0.1.28 upgrade txs (#1721)
  [Upgrade] Add v0.1.28 upgrade plan (#1720)
  [CometBFT] Use Pocket's fork temporarily (#1717)
  Use use_cometbft_fork_v038.17 (#1714)
  [RelayMiner] Add session lifetime caching (#1713)
  Update recovery allowlist for recovery-8aug2025 (#1716)
  [Tokenomics] Validator proper decoding (#1710)
  [Session Rollovers] First attempt at solving session rollovers from RelayMiner's POV (#1705)
  [RelayMiner] Add comprehensive relay timing and gRPC call metrics (#1703)
  [Shared Module] Increase `ComputeUnitsPerRelayMax` (#1709)
  [RelayMiner] Improve non-2xx errors visibility, do not mine 5xx (#1695)
  [Governance] - Updated Params to match the ones in the forum  (#1707)
  [RelayMiner] Improve RelayMiner timeout handling and test reliability (#1691)
  [Morse Recovery] Updated Allowlist for Recovery (#1696)
  ...
bryanchriswhite added a commit that referenced this pull request Aug 15, 2025
* feat/ibc/packet-forward-middleware: (36 commits)
  [GOVERNANCE][PARAMS][CUTTM] Updating global CUTTM per Foundation requirement (#1727)
  Update docusaurus/docs/4_develop/upgrades/4_upgrade_list.md w/ v0.1.28 MainNet block
  Updating bulk_params_main/tokenomics_params.json so proposer gets rewards again
  Update upgrade_tx_v0.1.28_main.json
  [Morse Recovery] Add recovery allowlist entries for issues #1718 and #1719 (#1723)
  [Upgrade]: Update v0.1.28 upgrade list docs (#1722)
  [Upgrade] v0.1.28 upgrade txs (#1721)
  [Upgrade] Add v0.1.28 upgrade plan (#1720)
  [CometBFT] Use Pocket's fork temporarily (#1717)
  Use use_cometbft_fork_v038.17 (#1714)
  [RelayMiner] Add session lifetime caching (#1713)
  Update recovery allowlist for recovery-8aug2025 (#1716)
  [Tokenomics] Validator proper decoding (#1710)
  [Session Rollovers] First attempt at solving session rollovers from RelayMiner's POV (#1705)
  [RelayMiner] Add comprehensive relay timing and gRPC call metrics (#1703)
  [Shared Module] Increase `ComputeUnitsPerRelayMax` (#1709)
  [RelayMiner] Improve non-2xx errors visibility, do not mine 5xx (#1695)
  [Governance] - Updated Params to match the ones in the forum  (#1707)
  [RelayMiner] Improve RelayMiner timeout handling and test reliability (#1691)
  [Morse Recovery] Updated Allowlist for Recovery (#1696)
  ...

# Conflicts:
#	tiltfiles/ibc.tilt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devnet devnet-test-e2e off-chain Off-chain business logic proxy Changes related to the Proxy push-image CI related - pushes images to ghcr.io relayminer Changes related to the Relayminer

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants