Add grayscale shader #6662
Merged
Add grayscale shader #6662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Collaborator
Contributor
Author
|
Probably not only because buffered container is slow :( |
bdach
requested changes
Oct 27, 2025
Co-authored-by: Bartłomiej Dach <[email protected]>
bdach
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposed as
BufferedContainer.GrayscaleStrengthfor now, with transform support viaGrayscaleTo().I think in the future we're going to have to turn
BufferedContainerinto more of an "EffectContainer" with particular passes (grayscale being one of them) that can be attached, but this should be fine for now?Using the HSP algorithm with the same parameters as defined in osu!. Maybe this can be adjustable in the future but I'm not thinking too far ahead right now.
Intended for effects such as:
2025-10-27.18-55-25.mp4