Conversation
6b937f2 to
276c61f
Compare
276c61f to
a857999
Compare
|
Please learn to split out and name your commits better. They should describe what you are doing inside them. |
| { | ||
| Text = ChangelogEntry.Users > 0 ? | ||
| string.Join(" ", ChangelogEntry.Users.ToString("N0"), "users online"): | ||
| string.Format($"{ChangelogEntry.Users:N0} users online") : |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Add OnClick to TooltipIconButton; Actions on pressing previous/next in builds
+ provoke angry AppVeyor
Apply fixes to things pointed out by AppVeyor
Disable sounds when disabled; Remove default tooltip texts
|
@HoutarouOreki This is all done now. working your code into a good state probably took 2-3x what it would have been writing from scratch, but i hope looking through my commits (and the approach to how i went about fixing pieces) is helpful to you. Make sure to check our all the pull requests and fixes which spawned from this implementation (added to the original description of this PR). |
|
@peppy do a visual pass on it once more and check my recent commits. |
Mostly resolves #2886
Ready for reviews.
Chart (API works)Use no-break-space fornot working$" by {entry.GithubUser.DisplayName}"ppy takeover