Skip to content

Changelog overlay#3074

Merged
peppy merged 205 commits intoppy:masterfrom
HoutarouOreki:changelog-overlay
May 31, 2019
Merged

Changelog overlay#3074
peppy merged 205 commits intoppy:masterfrom
HoutarouOreki:changelog-overlay

Conversation

@HoutarouOreki
Copy link
Contributor

@HoutarouOreki HoutarouOreki commented Jul 19, 2018

@peppy
Copy link
Member

peppy commented Jul 20, 2018

Please learn to split out and name your commits better. They should describe what you are doing inside them.

{
Text = ChangelogEntry.Users > 0 ?
string.Join(" ", ChangelogEntry.Users.ToString("N0"), "users online"):
string.Format($"{ChangelogEntry.Users:N0} users online") :

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

@peppy
Copy link
Member

peppy commented May 24, 2019

@HoutarouOreki This is all done now. working your code into a good state probably took 2-3x what it would have been writing from scratch, but i hope looking through my commits (and the approach to how i went about fixing pieces) is helpful to you.

Make sure to check our all the pull requests and fixes which spawned from this implementation (added to the original description of this PR).

@smoogipoo
Copy link
Contributor

@peppy do a visual pass on it once more and check my recent commits.

@peppy peppy merged commit e017350 into ppy:master May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Changelog overlay

7 participants