Skip to content

Add ExpandingBar UI element#4844

Merged
smoogipoo merged 2 commits intoppy:masterfrom
peppy:expanding-bar
May 23, 2019
Merged

Add ExpandingBar UI element#4844
smoogipoo merged 2 commits intoppy:masterfrom
peppy:expanding-bar

Conversation

@peppy
Copy link
Member

@peppy peppy commented May 22, 2019

Used in a few different areas across the current design language.

@peppy peppy added type/cosmetic Only affects the game visually. Doesn't affect things working or not working. design labels May 22, 2019
@HoutarouOreki HoutarouOreki mentioned this pull request May 22, 2019
18 tasks
/// A rounded bar which can be expanded or collapsed.
/// Generally used for tabs or breadcrumbs.
/// </summary>
public class ExpandingBar : Circle
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any game-specific code here. Why this class is not in the framework?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it's osu! design.

@smoogipoo smoogipoo merged commit 484f566 into ppy:master May 23, 2019
@peppy peppy deleted the expanding-bar branch May 31, 2019 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/cosmetic Only affects the game visually. Doesn't affect things working or not working.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants