Improve error message of include#2066
Merged
nickclark2016 merged 1 commit intopremake:masterfrom Aug 9, 2023
Merged
Conversation
`"Error: cannot open $name: No such file or directory"` (from `dofile`) to `"Error: Cannot find either $name or $name.lua or $name/premake5.lua or $name/premake4.lua"`
nickclark2016
approved these changes
Aug 9, 2023
Contributor
Author
|
@nickclark2016 : That PR seems to break premake :-/, I got: You might revert that PR currently. Sorry for the inconveniences. I need to investigate what change, as I pretty sure I didn't have that when testing that code :/ (Integrating tests would have caught that ;-) ) |
Member
|
I trusted you :( Reverting |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Change error message for include/includeexternal from
"Error: cannot open $name: No such file or directory"(fromdofile) to"Error: Cannot find either $name or $name.lua or $name/premake5.lua or $name/premake4.lua"How does this PR change Premake's behavior?
Error message change.
Anything else we should know?
Done after viewing https://stackoverflow.com/questions/75986260/include-path-not-detected-when-running-premake
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!