Fix premake.findProjectScript of previous commit.#2122
Merged
nickclark2016 merged 1 commit intopremake:masterfrom Aug 17, 2023
Merged
Fix premake.findProjectScript of previous commit.#2122nickclark2016 merged 1 commit intopremake:masterfrom
premake.findProjectScript of previous commit.#2122nickclark2016 merged 1 commit intopremake:masterfrom
Conversation
Member
nickclark2016
left a comment
nickclark2016
left a comment
There was a problem hiding this comment.
Just a minor nit, can we give f a more descriptive name? Other than that, LGTM.
Contributor
Author
|
Any proposal? |
Member
|
Either the first or last is fine to me. Just something that gives me an idea of what's going on if I've gotta touch that code in the future. |
Contributor
Author
|
Renamed to |
nickclark2016
approved these changes
Aug 17, 2023
Member
|
Just a sanity check, but this is verified, correct? |
Contributor
Author
|
Verified locally and with: premake-sample-projects/actions (Test fix for premake master.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix #2066
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)