fix: augment vue rather than @vue/runtime-core#71
Merged
lihbr merged 1 commit intoprismicio:masterfrom Aug 28, 2024
Merged
Conversation
Member
|
Thank you so much! We'll release that soon |
Contributor
Author
|
Hey @lihbr, thanks for merging! Do you know when this is going to be released? This is preventing us from upgrading to the latest version of nuxt 😔 |
Member
|
Hi @StevenPewsey, thanks for pinging me! I was hoping #72 would get in faster but the other teams aren't there yet. Anyway, just released a patch with your PR 🎉 |
Contributor
Author
|
@lihbr legend, thank you so much! ⭐ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
For a while, in the Vue ecosystem we've been augmenting @vue/runtime-core to add custom properties and more to vue. However, this inadvertently breaks the types for projects that augment vue - which is (now?) the officially recommended in the docs way to augment these interfaces (for example, ComponentCustomProperties, GlobalComponents and so on).
This means all libraries must update their code (or it will break the types of the libraries that augment vue instead).
Here's an example of how the augmented types end up broken.
This PR is a small effort to ensure the ecosystem is consistent. For context, you can see that vue-router has vuejs/router#2295, as well as nuxt/nuxt#28542.
Checklist: