Conversation
xrutayisire
approved these changes
Aug 28, 2024
Contributor
xrutayisire
left a comment
xrutayisire
left a comment
There was a problem hiding this comment.
LGTM of course! Thank you so much for the PR!
We can take over as soon as we do the release process, to merge it and release a new version of the package.
xrutayisire
reviewed
Aug 29, 2024
Co-authored-by: Xavier Rutayisire <xavier.rutayisire@gmail.com>
This reverts commit a606ff7.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Let's wait for client stable release before merging 🙏
Checklist: