Update cmake & clang tidy & rewriting binary read-in#708
Merged
landinjm merged 17 commits intoprisms-center:masterfrom Oct 9, 2025
Merged
Update cmake & clang tidy & rewriting binary read-in#708landinjm merged 17 commits intoprisms-center:masterfrom
landinjm merged 17 commits intoprisms-center:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is going to be a big pull request, but it's morphed into something I can't split up easily right now. Nonetheless, I'll try and explain everything I've done well.
Binary read-in
I finally got around to looking at the code in #691 after fixing some CMake stuff that lets up run unit tests from the main directory. I found out that the feature didn't support vector fields. I decided to rewrite it. Here's a shortlist of what I did
Check out In
read_binary.hallow for widening and narrowing of types #707 for a feature we should probably add.Clang-tidy
This is still a WIP, but I've been working on getting that workflow to pass.
Closes #698
CMake
This is the bulk of the work I did.
make run_teststarget that runs the unit testsmake debug,make release, andmake debugreleasetargets to compile the debug executable, release executable, and both. Note that the release executable has been renamed frommain->main-releasemake installwhen configuredmake installwhen configuredCloses #533, #390, #688, #527, #706, #681, #668, #390, #314