Conversation
- kNewHeads is called once for each block, so event is never duplicate - data race, 2 blocks became head before first event, so heads didn't change between first and second event, so second event was ignored Signed-off-by: turuslan <turuslan.devbox@gmail.com>
iceseer
approved these changes
Apr 24, 2025
kamilsa
approved these changes
Apr 24, 2025
Lederstrumpf
pushed a commit
to Lederstrumpf/kagome
that referenced
this pull request
May 20, 2025
- kNewHeads is called once for each block, so event is never duplicate - data race, 2 blocks became head before first event, so heads didn't change between first and second event, so second event was ignored Signed-off-by: turuslan <turuslan.devbox@gmail.com>
kamilsa
pushed a commit
that referenced
this pull request
Jun 10, 2025
- kNewHeads is called once for each block, so event is never duplicate - data race, 2 blocks became head before first event, so heads didn't change between first and second event, so second event was ignored Signed-off-by: turuslan <turuslan.devbox@gmail.com> (cherry picked from commit 76e011d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Referenced issues
Description of the Change
kViewUpdatedevent.kNewHeadsis called once for each block, so event is never duplicatePossible Drawbacks