Skip to content

peer view miss event #2445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
turuslan merged 1 commit into from
Apr 24, 2025
Merged

peer view miss event #2445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions core/network/impl/peer_view.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,6 @@ namespace kagome::network {
.new_head = header,
.lost = {},
};
if (event.view == my_view_) {
return;
}
my_view_stripped_ = std::move(stripped_view);
for (const auto &head : my_view_.heads_) {
if (not event.view.contains(head)) {
Expand Down
4 changes: 4 additions & 0 deletions core/network/impl/protocols/parachain.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,10 @@ namespace kagome::network {
}

void ParachainProtocol::write(const View &view) {
if (view == last_sent_view_) {
return;
}
last_sent_view_ = view;
auto message = encodeView(view);
notifications_->peersOut([&](const PeerId &peer_id, size_t protocol_group) {
notifications_->write(peer_id, protocol_group, message);
Expand Down
2 changes: 1 addition & 1 deletion core/network/impl/protocols/parachain.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ namespace kagome::network {
class PeerView;
struct Seconded;
class ValidationObserver;
struct View;
} // namespace kagome::network

namespace kagome::network {
Expand Down Expand Up @@ -76,6 +75,7 @@ namespace kagome::network {
primitives::events::SyncStateSubscriptionEnginePtr sync_engine_;
std::shared_ptr<void> sync_sub_;
std::shared_ptr<void> my_view_sub_;
View last_sent_view_;
// NOLINTEND(cppcoreguidelines-non-private-member-variables-in-classes)
};

Expand Down
Loading