Allow larger autocorrect dictionaries via configurable link size#25838
Allow larger autocorrect dictionaries via configurable link size#25838MustafaNisar2002 wants to merge 5 commits intoqmk:developfrom
Conversation
Clarified autocorrect functionality and improved documentation.
| # error "AUTOCORRECT_LINK_BYTE_COUNT must be either 2 or 3 bytes." | ||
| #endif | ||
|
|
||
| #if defined(__AVR__) && DICTIONARY_SIZE > UINT16_MAX |
There was a problem hiding this comment.
We would not accept platform specific logic in core, when there is an abstraction in place that already exists.
platforms/progmem.h would need to be updated to add pgm_read_byte_far compatibility.
| #if defined(__AVR__) && DICTIONARY_SIZE > UINT16_MAX | |
| #if DICTIONARY_SIZE > UINT16_MAX |
|
You also have both |
|
Thank you for your contribution! |
|
Thank you for your contribution! |
Description
This PR relaxes the size limit on autocorrect dictionaries so tables larger than 64KB can be generated and used safely.
AUTOCORRECT_LINK_BYTE_COUNTdefined in the generated header.AUTOCORRECT_LINK_BYTE_COUNTin generatedautocorrect_data.hfiles and annotate the default autocorrect dictionary with its link size.docs/features/autocorrect.md.Types of Changes
Issues Fixed or Closed by This PR
Checklist
python -m compileall lib/python/qmk/cli/generate/autocorrect_data.pyand firmware builds with a generated dictionary).