Open
Conversation
Even if memcpy_P appears to work. This is probably safer.
drashna
commented
Feb 10, 2026
Comment on lines
+55
to
63
| static inline uint32_t autocorrect_read_state(uint32_t state) { | ||
| uint32_t new_state = 0; | ||
|
|
||
| for (uint8_t i = 0; i < current_dict_node_size; ++i) { | ||
| new_state |= (uint32_t)AUTOCORRECT_PGM_READ_BYTE(state + 1 + i) << (8 * i); | ||
| } | ||
|
|
||
| return new_state; | ||
| } |
Member
Author
There was a problem hiding this comment.
This seems to work in place of this, but really just ignores the pgm near vs far part. Testing on AVR and ARM, this seems to work fine (not tested on avr that would actually use the far function, though).
memcpy_P(&state, current_dict_data + state + 1, sizeof(state));
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This includes a number of other PRs (#25838, #22788) and other additional changes. Specifically:
Types of Changes
Issues Fixed or Closed by This PR
Checklist