fix(opencode): fix permission matching and add escalation after 3 attempts (#387, #388)#389
Merged
fix(opencode): fix permission matching and add escalation after 3 attempts (#387, #388)#389
Conversation
randomm
changed the title
- Issue #387: Fix disabled() to use evaluate() for consistency. Adversarial-pipeline agent tools (taskctl, bash) were incorrectly disabled due to wildcard deny rule, despite being explicitly allowed by specific rules. - Issue #388: Escalation logic already working correctly (MAX_ADVERSARIAL_ATTEMPTS = 3 at pulse-verdicts.ts:21)
…ct-match-precedence semantics
- Fix evaluate() to use correct last-match-wins semantics - Add Wildcard.isWildcard() utility function - Fix test expectation for disabled() checking with pattern '*' - All permission-task.test.ts tests now pass (21/21)
- Remove 9 debug/exploration scripts from PR - Remove .opencode/tasks/ pipeline artifacts - Fix merge() indentation (2 spaces) - Remove unused isWildcard() function - Add skipIf guards to Cloudflare/Bedrock tests (require credentials) Addresses five-pass code review findings for PR #389
This was referenced Apr 7, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #387, #388