Conversation
…#401) - Simplified duplicate condition check in disabled() - single if block - Updated 4 tests in permission-task.test.ts for new visibility semantic - Updated comments from findLast() to last-match-wins
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #401
Root Cause
PR #389 rewrote
disabled()to useevaluate(permission, "*", ruleset)for consistency withevaluate(). However,"*"as the query pattern only matches wildcard rule patterns — specific patterns like"ops"or"developer"are invisible becauseWildcard.match("*", "ops")returns false. This caused tools with per-subagent configs like{ "task": { "*": "deny", "ops": "allow" } }to be incorrectly hidden.Fix
disabled()now checks if ANY allow rule exists for the permission (regardless of pattern) before hiding. A tool is only disabled if no allow rule exists AND the default evaluates to deny.Changes
packages/opencode/src/permission/next.ts: AddedhasAllowcheck before disabling tools; added JSDoc documentationpackages/opencode/test/permission/next.test.ts: Flipped incorrect test expectation; added 7 new tests covering per-subagent configs, deny-only, glob allows, and wildcard collisionQuality Gates