Changes needed for CCCL 3.2 compatibility#20810
Merged
rapids-bot[bot] merged 8 commits intorapidsai:mainfrom Dec 18, 2025
Merged
Changes needed for CCCL 3.2 compatibility#20810rapids-bot[bot] merged 8 commits intorapidsai:mainfrom
rapids-bot[bot] merged 8 commits intorapidsai:mainfrom
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
bdice
changed the title
Contributor
Author
|
/ok to test |
bdice
added
improvement
Contributor
Author
|
/ok to test |
33 tasks
bdice
force-pushed
the
cccl-3.2.x-compatibility
branch
from
d71aad5 to
45683f2
Compare
bdice
changed the title
PointKernel
reviewed
Dec 16, 2025
davidwendt
approved these changes
Dec 16, 2025
ttnghia
reviewed
Dec 16, 2025
Comment on lines
+128
to
+129
| cuda::proclaim_return_type<detail::row::lhs_index_type>( | ||
| [] __device__(size_type idx) { return static_cast<detail::row::lhs_index_type>(idx); })); |
Contributor
There was a problem hiding this comment.
I thought that proclaim_return_type was no longer needed if the lambda's return type is obvious (like this one)?
Contributor
Author
There was a problem hiding this comment.
No, this is needed to compile in some cases where deduction is not possible for the compiler. These were needed to fix compiler errors.
Contributor
There was a problem hiding this comment.
I'm surprised that such issue still happens with this "trivial" code, since it looks very obvious to deduce the output type:
return static_cast<detail::row::lhs_index_type>(....);
So I consider this as a regression in CCCL 3.2.
github-actions
bot
added
Python
vyasr
approved these changes
Dec 17, 2025
Contributor
Author
|
/merge |
PointKernel
approved these changes
Dec 17, 2025
ttnghia
approved these changes
Dec 17, 2025
Contributor
Author
|
/merge |
PointKernel
added a commit
to NVIDIA/cuCollections
that referenced
this pull request
Dec 19, 2025
Similar to rapidsai/cudf#20810 This PR contains the updates needed for CCCL 3.2, resolving the build errors that occur when upgrading the CCCL version from 3.1 to 3.2 in rapids-cmake: rapidsai/rapids-cmake#955
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This refactors some C++ code, particularly memory resources, to make it compatible with CCCL 3.2.
Checklist