-
Notifications
You must be signed in to change notification settings - Fork 1k
Changes needed for CCCL 3.2 compatibility #20810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
a331aae
ccc1fc8
a0daec9
45683f2
3e2da92
0040eab
c8fcc51
496ac51
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,6 +22,7 @@ | |
| #include <rmm/cuda_stream_view.hpp> | ||
| #include <rmm/exec_policy.hpp> | ||
|
|
||
| #include <cuda/functional> | ||
| #include <cuda/std/iterator> | ||
| #include <cuda/std/tuple> | ||
| #include <thrust/binary_search.h> | ||
|
|
@@ -124,7 +125,8 @@ merge<LargerIterator, SmallerIterator>::matches_per_row(rmm::cuda_stream_view st | |
| auto match_counts_it = match_counts.begin(); | ||
| auto smaller_it = thrust::transform_iterator( | ||
| sorted_smaller_order_begin, | ||
| [] __device__(size_type idx) { return static_cast<detail::row::lhs_index_type>(idx); }); | ||
| cuda::proclaim_return_type<detail::row::lhs_index_type>( | ||
| [] __device__(size_type idx) { return static_cast<detail::row::lhs_index_type>(idx); })); | ||
|
Comment on lines
+128
to
+129
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I thought that
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No, this is needed to compile in some cases where deduction is not possible for the compiler. These were needed to fix compiler errors.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm surprised that such issue still happens with this "trivial" code, since it looks very obvious to deduce the output type: So I consider this as a regression in CCCL 3.2. |
||
| thrust::upper_bound(rmm::exec_policy_nosync(stream), | ||
| smaller_it, | ||
| smaller_it + smaller_numrows, | ||
|
|
@@ -212,10 +214,12 @@ merge<LargerIterator, SmallerIterator>::operator()(rmm::cuda_stream_view stream, | |
| }); | ||
| auto smaller_it = thrust::transform_iterator( | ||
| sorted_smaller_order_begin, | ||
| [] __device__(size_type idx) { return static_cast<detail::row::lhs_index_type>(idx); }); | ||
| cuda::proclaim_return_type<detail::row::lhs_index_type>( | ||
| [] __device__(size_type idx) { return static_cast<detail::row::lhs_index_type>(idx); })); | ||
| auto larger_it = thrust::transform_iterator( | ||
| nonzero_matches.begin(), | ||
| [] __device__(size_type idx) { return static_cast<detail::row::rhs_index_type>(idx); }); | ||
| cuda::proclaim_return_type<detail::row::rhs_index_type>( | ||
| [] __device__(size_type idx) { return static_cast<detail::row::rhs_index_type>(idx); })); | ||
| thrust::lower_bound(rmm::exec_policy_nosync(stream), | ||
| smaller_it, | ||
| smaller_it + smaller_numrows, | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.