Refactor limiting_resource_adaptor to shared CCCL MR design#2277
Merged
bdice merged 5 commits intorapidsai:stagingfrom Mar 10, 2026
Merged
Refactor limiting_resource_adaptor to shared CCCL MR design#2277bdice merged 5 commits intorapidsai:stagingfrom
bdice merged 5 commits intorapidsai:stagingfrom
Conversation
Convert limiting_resource_adaptor from a class template to a non-template class using the shared_resource pattern. The adaptor now: - Splits implementation into detail/limiting_resource_adaptor_impl.hpp and src/mr/detail/limiting_resource_adaptor_impl.cpp - Inherits private cuda::mr::shared_resource<detail::limiting_resource_adaptor_impl> - Accepts device_async_resource_ref upstream (not raw pointer) - Retains device_memory_resource* constructor overload for backward compat - Exposes get_property for cuda::mr::device_accessible - Is copyable via shared_resource (shared ownership semantics) Add mr_ref_limiting_tests.cpp with CcclMrRef test instantiations. Add limiting_resource_adaptor to cccl_adaptor_tests.cpp typed test suite. Update adaptor_tests.cpp, limiting_mr_tests.cpp, pool_mr_tests.cpp. Update Cython pxd/pyx bindings to match non-template C++ signature.
bdice
added
breaking
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Collaborator
Author
|
/ok to test 007ace6 |
Collaborator
Author
|
/ok to test |
Collaborator
Author
|
This looks good, it's mostly aligned with the other MR refactorings aside from cleanup tasks I've already marked down for later. I'll admin-merge this once CI passes. |
Collaborator
Author
|
/ok to test |
Collaborator
Author
|
/ok to test |
bdice
requested review from
PointKernel and
miscco
and removed request for
a team
44 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
limiting_resource_adaptorimplementation intodetail/limiting_resource_adaptor_impl.hpp+src/mr/detail/limiting_resource_adaptor_impl.cpp, usingcuda::mr::shared_resourcefor shared ownershipdevice_async_resource_refupstream; class is now non-templatemr_ref_limiting_tests.cppand integrate intocccl_adaptor_tests.cpptyped test suiteadaptor_tests.cpptype aliases,NullUpstream,Equality, andowning_wrapperEquality tests for non-template type withshared_resourcesemantics.pxd/.pyxbindings to match non-template C++ signature