Refactor failure_callback_resource_adaptor to shared CCCL MR design#2278
Merged
bdice merged 3 commits intorapidsai:stagingfrom Mar 10, 2026
Merged
Refactor failure_callback_resource_adaptor to shared CCCL MR design#2278bdice merged 3 commits intorapidsai:stagingfrom
bdice merged 3 commits intorapidsai:stagingfrom
Conversation
bdice
added
breaking
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Collaborator
Author
|
/ok to test 23677c9 |
Collaborator
Author
|
Self-reviewed -- this is aligned with the other refactorings. I will admin-merge this after resolving conflicts with #2277. |
Resolve merge conflicts in adaptor_tests.cpp by combining both de-templating changes: failure_callback_resource_adaptor<> (this branch) and limiting_resource_adaptor (staging).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
failure_callback_resource_adaptorimplementation intodetail/failure_callback_resource_adaptor_impl.hpp(header-only, since impl is templated onExceptionType)device_async_resource_refupstream; template parameter changes from<Upstream, ExceptionType>to<ExceptionType>onlymr_ref_failure_callback_tests.cppand integrate intocccl_adaptor_tests.cpptyped test suiteadaptor_tests.cpptype aliases,NullUpstream, andEqualitytests.pxd/.pyxbindings to use[ExceptionType]template parameter without_of_memoryforward decl