[Serve] Remove shutdown() method from TaskProcessorAdapter#59713
Merged
abrarsheikh merged 4 commits intoray-project:masterfrom Dec 30, 2025
Merged
[Serve] Remove shutdown() method from TaskProcessorAdapter#59713abrarsheikh merged 4 commits intoray-project:masterfrom
abrarsheikh merged 4 commits intoray-project:masterfrom
Conversation
…stop_consumer() Signed-off-by: krisselberg <kselberg@princeton.edu>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a critical issue in the task_consumer's __del__ method by removing the call to shutdown(). This change prevents a broadcast shutdown of all workers when a single replica is terminated, which is crucial for the stability of rolling updates. The fix is well-justified and implemented correctly.
The new unit test test_task_consumer_cleanup_only_calls_stop_consumer is an excellent addition. It clearly verifies the intended behavior and ensures this regression won't occur in the future.
I've added one minor comment regarding the test implementation, suggesting a potential future refactoring for the mock object to improve test isolation. Overall, this is a high-quality contribution that improves the robustness of Ray Serve.
ray-gardener
bot
added
serve
Contributor
|
@harshit-anyscale could you take a look |
harshit-anyscale
requested changes
Dec 29, 2025
Signed-off-by: krisselberg <kselberg@princeton.edu>
…risselberg/ray into fix-task-consumer-del-shutdown Signed-off-by: krisselberg <kselberg@princeton.edu>
krisselberg
changed the title
AYou0207
pushed a commit
to AYou0207/ray
that referenced
this pull request
Jan 13, 2026
…ct#59713) ## Description Fix @task_consumer decorator's __del__ method calling shutdown() which broadcasts to all Celery workers instead of just the local one. This kills newly started workers during rolling updates. ## Related issues None ## Additional information Removed self._adapter.shutdown() from __del__ - only stop_consumer() should be called since it targets the specific worker hostname. Also removed shutdown() implementation & from interface given it is not used anywhere --------- Signed-off-by: krisselberg <kselberg@princeton.edu> Signed-off-by: jasonwrwang <jasonwrwang@tencent.com>
lee1258561
pushed a commit
to pinterest/ray
that referenced
this pull request
Feb 3, 2026
…ct#59713) ## Description Fix @task_consumer decorator's __del__ method calling shutdown() which broadcasts to all Celery workers instead of just the local one. This kills newly started workers during rolling updates. ## Related issues None ## Additional information Removed self._adapter.shutdown() from __del__ - only stop_consumer() should be called since it targets the specific worker hostname. Also removed shutdown() implementation & from interface given it is not used anywhere --------- Signed-off-by: krisselberg <kselberg@princeton.edu>
peterxcli
pushed a commit
to peterxcli/ray
that referenced
this pull request
Feb 25, 2026
…ct#59713) ## Description Fix @task_consumer decorator's __del__ method calling shutdown() which broadcasts to all Celery workers instead of just the local one. This kills newly started workers during rolling updates. ## Related issues None ## Additional information Removed self._adapter.shutdown() from __del__ - only stop_consumer() should be called since it targets the specific worker hostname. Also removed shutdown() implementation & from interface given it is not used anywhere --------- Signed-off-by: krisselberg <kselberg@princeton.edu> Signed-off-by: peterxcli <peterxcli@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix @task_consumer decorator's del method calling shutdown() which broadcasts to all Celery workers instead of just the local one. This kills newly started workers during rolling updates.
Related issues
None
Additional information
Removed self._adapter.shutdown() from del - only stop_consumer() should be called since it targets the specific worker hostname. Also removed shutdown() implementation & from interface given it is not used anywhere