Skip to content

[Serve] Remove shutdown() method from TaskProcessorAdapter #59713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abrarsheikh merged 4 commits into from
Dec 30, 2025
Merged

[Serve] Remove shutdown() method from TaskProcessorAdapter #59713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8390b19
[Serve] Fix task_consumer __del__ calling shutdown() instead of only …
krisselberg Dec 27, 2025
b4486b0
Merge branch 'master' into fix-task-consumer-del-shutdown
krisselberg Dec 28, 2025
5f0195f
Remove unused shutdown() method from TaskProcessorAdapter
krisselberg Dec 29, 2025
fbe4302
Merge branch 'fix-task-consumer-del-shutdown' of https://github.com/k…
krisselberg Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions python/ray/serve/schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1582,13 +1582,6 @@ def stop_consumer(self, timeout: float = 10.0):
"""
pass

@abstractmethod
def shutdown(self):
"""
Shutdown the task processor and clean up resources.
"""
pass

@abstractmethod
def cancel_task_sync(self, task_id: str):
"""
Expand Down
1 change: 0 additions & 1 deletion python/ray/serve/task_consumer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,6 @@ def initialize_callable(self, consumer_concurrency: int):

def __del__(self):
self._adapter.stop_consumer()
self._adapter.shutdown()

if hasattr(target_cls, "__del__"):
target_cls.__del__(self)
Expand Down
5 changes: 0 additions & 5 deletions python/ray/serve/task_processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,11 +225,6 @@ def stop_consumer(self, timeout: float = 10.0):

self._worker_thread = None

def shutdown(self):
logger.info("Shutting down Celery worker...")
self._app.control.shutdown()
logger.info("Celery worker shutdown complete...")

def cancel_task_sync(self, task_id):
"""
Cancels a task synchronously. Only supported for Redis and RabbitMQ brokers by Celery.
Expand Down
4 changes: 0 additions & 4 deletions python/ray/serve/tests/unit/test_task_consumer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ class MockTaskProcessorAdapter(TaskProcessorAdapter):

_start_consumer_received: bool = False
_stop_consumer_received: bool = False
_shutdown_received: bool = False

def __init__(self, config: TaskProcessorConfig):
self._config = config
Expand All @@ -46,9 +45,6 @@ def start_consumer(self, **kwargs):
def stop_consumer(self, timeout: float = 10.0):
self._stop_consumer_received = True

def shutdown(self):
self._shutdown_received = True

def cancel_task_sync(self, task_id) -> bool:
pass

Expand Down