Skip to content

Remove error caused by hiredis ssl not supported #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
byroot merged 2 commits into from
Feb 21, 2022
+0 −13
Merged

Remove error caused by hiredis ssl not supported #1077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86df222
remove hiredis ssl not implemented exception
ke-miz Feb 21, 2022
1262e75
remove hiredis test for ssl option
ke-miz Feb 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions lib/redis/connection/hiredis.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ def self.connect(config)

if config[:scheme] == "unix"
connection.connect_unix(config[:path], connect_timeout)
elsif config[:scheme] == "rediss" || config[:ssl]
raise NotImplementedError, "SSL not supported by hiredis driver"
else
connection.connect(config[:host], config[:port], connect_timeout)
end
Expand Down
11 changes: 0 additions & 11 deletions test/ssl_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,17 +46,6 @@ def test_ssl_blocking
end
end

driver(:hiredis, :synchrony) do
def test_ssl_not_implemented_exception
assert_raises(NotImplementedError) do
RedisMock.start({ ping: proc { "+PONG" } }, ssl_server_opts("trusted")) do |port|
redis = Redis.new(port: port, ssl: true, ssl_params: { ca_file: ssl_ca_file })
redis.ping
end
end
end
end

private

def ssl_server_opts(prefix)
Expand Down