You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
You're right, but I disagree it should be reverted. If an adapter doesn't support something, it should raise itself, not rely on redis-rb to prevent that call from happening.
I'd rather leave it as is. And once I migrate redis-rb to use redis-client it won't matter anymore since it supports SSL with hiredis.
Oh, great, redis-client looks much better than the current state of hiredis-rb.
If an adapter doesn't support something, it should raise itself, not rely on redis-rb to prevent that call from happening.
In this case, lib/redis/connection/hiredis.rb doesn't ever let hiredis-rb know that SSL is being used, so how would that work at the moment? I think hiredis-rb would need to be modified to take in the scheme or SSL options, and then raise the exception.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSL support in hiredis was merged three years ago. So no need for ssl error anymore.
#828