Skip to content

Remove error caused by hiredis ssl not supported#1077

Merged
byroot merged 2 commits intoredis:masterfrom
ke-miz:remove-error-caused-by-hiredis-ssl-not-supported
Feb 21, 2022
Merged

Remove error caused by hiredis ssl not supported#1077
byroot merged 2 commits intoredis:masterfrom
ke-miz:remove-error-caused-by-hiredis-ssl-not-supported

Conversation

@ke-miz
Copy link
Copy Markdown
Contributor

@ke-miz ke-miz commented Feb 21, 2022

SSL support in hiredis was merged three years ago. So no need for ssl error anymore.
#828

@byroot byroot merged commit a7c2a5b into redis:master Feb 21, 2022
@ke-miz ke-miz deleted the remove-error-caused-by-hiredis-ssl-not-supported branch February 21, 2022 09:56
@stanhu
Copy link
Copy Markdown

stanhu commented Aug 10, 2022

@byroot @ke-miz This should be reverted. hiredis supports SSL, but hiredis-rb does not yet: redis/hiredis-rb#58 (comment)

@byroot
Copy link
Copy Markdown
Collaborator

byroot commented Aug 10, 2022

You're right, but I disagree it should be reverted. If an adapter doesn't support something, it should raise itself, not rely on redis-rb to prevent that call from happening.

I'd rather leave it as is. And once I migrate redis-rb to use redis-client it won't matter anymore since it supports SSL with hiredis.

@stanhu
Copy link
Copy Markdown

stanhu commented Aug 10, 2022

Oh, great, redis-client looks much better than the current state of hiredis-rb.

If an adapter doesn't support something, it should raise itself, not rely on redis-rb to prevent that call from happening.

In this case, lib/redis/connection/hiredis.rb doesn't ever let hiredis-rb know that SSL is being used, so how would that work at the moment? I think hiredis-rb would need to be modified to take in the scheme or SSL options, and then raise the exception.

@byroot
Copy link
Copy Markdown
Collaborator

byroot commented Aug 10, 2022

In this case, lib/redis/connection/hiredis.rb doesn't ever let hiredis-rb know that SSL is being used

Arf, right, I remembered the ssl: true being passed, but you're right it's not the case. I guess I'll revert ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants