Skip to content

Fix a description about SSL/TLS support drivers in readme#1083

Closed
supercaracal wants to merge 1 commit intoredis:masterfrom
supercaracal:fix-readme-for-ssl-hiredis
Closed

Fix a description about SSL/TLS support drivers in readme#1083
supercaracal wants to merge 1 commit intoredis:masterfrom
supercaracal:fix-readme-for-ssl-hiredis

Conversation

@supercaracal
Copy link
Copy Markdown
Contributor

@supercaracal supercaracal commented Feb 26, 2022

@supercaracal supercaracal marked this pull request as ready for review February 26, 2022 04:02
[OpenSSL::SSL::SSLContext documentation]: http://ruby-doc.org/stdlib-2.3.0/libdoc/openssl/rdoc/OpenSSL/SSL/SSLContext.html

*NOTE:* SSL is only supported by the default "Ruby" driver
*NOTE:* SSL is only supported by the default "Ruby" driver and [hiredis](https://github.com/redis/hiredis)
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that it is not enough to use the feature yet. Should we wait for to be able to use the feature of hiredis-rb?

def self.connect(config)
connection = ::Hiredis::Connection.new
connect_timeout = (config.fetch(:connect_timeout, 0) * 1_000_000).to_i
if config[:scheme] == "unix"
connection.connect_unix(config[:path], connect_timeout)
else
connection.connect(config[:host], config[:port], connect_timeout)
end
instance = new(connection)
instance.timeout = config[:read_timeout]
instance
rescue Errno::ETIMEDOUT
raise TimeoutError
end

@supercaracal
Copy link
Copy Markdown
Contributor Author

This PR is jumping the gun.

@supercaracal supercaracal deleted the fix-readme-for-ssl-hiredis branch March 1, 2022 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant