Skip to content

[v25.2.x] [CORE-14442] rm_stm: do not reinsert producer to active tx producers list if present#28312

Merged
piyushredpanda merged 1 commit intoredpanda-data:v25.2.xfrom
vbotbuildovich:backport-pr-28283-v25.2.x-850
Jan 17, 2026
Merged

[v25.2.x] [CORE-14442] rm_stm: do not reinsert producer to active tx producers list if present#28312
piyushredpanda merged 1 commit intoredpanda-data:v25.2.xfrom
vbotbuildovich:backport-pr-28283-v25.2.x-850

Conversation

@vbotbuildovich
Copy link
Copy Markdown
Collaborator

Backport of PR #28283

Recently we relaxed an assertion in the producer state. The assertion
trigger when control batch responsible for ending transaction was lost.
This should be treated as an error but it is possible as a result of
force recovery operation or other situation in which we accept a data
loss.

This PR adds a check verifying if producer is already in the active
transactional producers list when beginning transaction.

Previously without the check assertion was triggered.

Signed-off-by: Michał Maślanka <michal@redpanda.com>
(cherry picked from commit 9197536)
@vbotbuildovich vbotbuildovich added this to the v25.2.x-next milestone Nov 3, 2025
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Nov 3, 2025
@vbotbuildovich
Copy link
Copy Markdown
Collaborator Author

CI test results

test results on build#75466
test_class test_method test_arguments test_kind job_url test_status passed reason test_history
DataMigrationsApiTest test_mount_inexistent null integration https://buildkite.com/redpanda/redpanda/builds/75466#019a488e-15e7-465c-bccd-837abffc4308 FLAKY 20/21 upstream reliability is '100.0'. current run reliability is '95.23809523809523'. drift is 4.7619 and the allowed drift is set to 50. The test should PASS https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=DataMigrationsApiTest&test_method=test_mount_inexistent
DeleteRecordsTest test_delete_records_concurrent_truncations {"cloud_storage_enabled": true, "truncate_point": "at_high_watermark"} integration https://buildkite.com/redpanda/redpanda/builds/75466#019a488e-15df-46a8-b842-6437df805a54 FLAKY 16/21 upstream reliability is '85.71428571428571'. current run reliability is '76.19047619047619'. drift is 9.52381 and the allowed drift is set to 50. The test should PASS https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=DeleteRecordsTest&test_method=test_delete_records_concurrent_truncations
RedpandaKerberosConfigTest test_non_default null integration https://buildkite.com/redpanda/redpanda/builds/75466#019a488e-15ea-4831-b1b7-73628da8f8a9 FLAKY 20/21 upstream reliability is '66.33663366336634'. current run reliability is '95.23809523809523'. drift is -28.90146 and the allowed drift is set to 50. The test should PASS https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=RedpandaKerberosConfigTest&test_method=test_non_default
RedpandaOIDCTlsTest test_admin_invalidate_keys null integration https://buildkite.com/redpanda/redpanda/builds/75466#019a488e-15e8-4e54-bc5e-07f7f9ba51eb FLAKY 2/21 upstream reliability is '19.62025316455696'. current run reliability is '9.523809523809524'. drift is 10.09644 and the allowed drift is set to 50. The test should PASS https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=RedpandaOIDCTlsTest&test_method=test_admin_invalidate_keys
RedpandaOIDCTlsTest test_admin_revoke null integration https://buildkite.com/redpanda/redpanda/builds/75466#019a488e-15ea-4831-b1b7-73628da8f8a9 FLAKY 8/21 upstream reliability is '36.60130718954248'. current run reliability is '38.095238095238095'. drift is -1.49393 and the allowed drift is set to 50. The test should PASS https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=RedpandaOIDCTlsTest&test_method=test_admin_revoke
RedpandaOIDCTlsTest test_admin_whoami null integration https://buildkite.com/redpanda/redpanda/builds/75466#019a488e-15dd-4a55-bc21-4516a12fd608 FLAKY 1/21 upstream reliability is '12.376237623762377'. current run reliability is '4.761904761904762'. drift is 7.61433 and the allowed drift is set to 50. The test should PASS https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=RedpandaOIDCTlsTest&test_method=test_admin_whoami
TieredStorageTest test_tiered_storage {"cloud_storage_type_and_url_style": [1, "virtual_host"], "test_case": {"name": "(TS_Read == True, TS_Timequery == True, SpilloverManifestUploaded == True)"}} integration https://buildkite.com/redpanda/redpanda/builds/75466#019a4889-1732-40b0-ae51-f03ffc59bad6 FLAKY 20/21 upstream reliability is '97.61904761904762'. current run reliability is '95.23809523809523'. drift is 2.38095 and the allowed drift is set to 50. The test should PASS https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=TieredStorageTest&test_method=test_tiered_storage

@piyushredpanda piyushredpanda merged commit 884538b into redpanda-data:v25.2.x Jan 17, 2026
17 checks passed
@tyson-redpanda tyson-redpanda modified the milestones: v25.2.x-next, v25.2.14 Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/redpanda kind/backport PRs targeting a stable branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants